Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Some Playwright related fixes #4726

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

radical
Copy link
Member

@radical radical commented Jun 28, 2024

PR #4694 incorrectly disabled playwright tests when they should have been running. This inverts the condition to correctly disable for the failing case.

Related: #4623

  • [tests] Move HasPlaywrightSupport to PlaywrightProvider class
  • Fix condition disabling playwright based tests
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-components Issues pertaining to Aspire Component packages label Jun 28, 2024
@radical radical marked this pull request as ready for review June 29, 2024 00:26
@radical radical requested a review from eerhardt as a code owner June 29, 2024 00:26
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical radical merged commit 7166a5e into dotnet:main Jul 2, 2024
9 checks passed
@radical radical deleted the playwright-fixes branch July 2, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-components Issues pertaining to Aspire Component packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants