Audio has started playing at a slow speed with mono output (accessibility.monoaudio.enable)
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr115 | --- | unaffected |
firefox126 | --- | unaffected |
firefox127 | + | verified |
firefox128 | + | verified |
firefox129 | + | verified |
People
(Reporter: ke5trel, Assigned: padenot)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
pascalc
:
approval-mozilla-release+
|
Details | Review |
STR:
- Set
accessibility.monoaudio.enable = true
on Ubuntu 24.04. - Play a youtube video.
Audio is played slowly with low pitch, sounds like half speed.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e6f6e0723be0759e720d417dd4e2de7817f42d5&tochange=fb10bab6cd18b43ae0bd2ef55de94b9c9db3a3a3
Regressed by Bug 1889978.
Comment 1•29 days ago
|
||
:padenot, since you are the author of the regressor, bug 1889978, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Assignee | ||
Updated•29 days ago
|
Comment 2•29 days ago
|
||
[Tracking Requested - why for this release]: Per Paul, we should consider this for an uplift. accessibility.monoaudio.enable
is disabled by default, but may be manually set for accessibility reasons and the fix is likely to be small and low risk.
Comment 3•29 days ago
|
||
We could take a fix in the planned dot release.
Assignee | ||
Comment 4•25 days ago
|
||
Assignee | ||
Comment 5•25 days ago
|
||
Fix is absolutely trivial indeed, clearly something we can take in release. It's unfortunately not the easiest thing to test since we're not well setup to test audio output in CI.
Comment 6•24 days ago
|
||
Set release status flags based on info from the regressing bug 1889978
Pushed by [email protected]: https://hg.mozilla.org/mozilla-central/rev/95aeb046465a Properly pass the channel map instead of the channel count in FFmpegAudioDecoder.cpp. r=pehrsons
Comment 8•23 days ago
|
||
bugherder |
Comment 9•23 days ago
|
||
The patch landed in nightly and beta is affected.
:padenot, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox128
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 10•23 days ago
|
||
Comment on attachment 9406409 [details]
Bug 1900972 - Properly pass the channel map instead of the channel count in FFmpegAudioDecoder.cpp. r?#media-playback-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: An accessibility feature (
accessibility.monoaudio.enable
, that forces mono playback for all audio) is broken. It's unfortunately hard to write a test for this, but the patch is absolutely trivial. - Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Flip the pref:
accessibility.monoaudio.enable
, check the audio is the same pitch / speed as without the pref flipped (but it shouldn't be stereo anymore). - List of other uplifts needed: non
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): We're simply incorrectly specifying a value related to channel layout, there's no risk.
- String changes made/needed: none
- Is Android affected?: Yes
Assignee | ||
Updated•23 days ago
|
Updated•22 days ago
|
Comment 11•22 days ago
|
||
Comment on attachment 9406409 [details]
Bug 1900972 - Properly pass the channel map instead of the channel count in FFmpegAudioDecoder.cpp. r?#media-playback-reviewers
Approved for 128.0b3.
Updated•22 days ago
|
Comment 12•22 days ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/dd1b7a293c20
Comment 13•21 days ago
|
||
I've reproduced this issue using an affected Nightly build from 2024-06-06, on macOS 14.
The issue is verified as fixed on latest Nightly 129.0a1 and Beta 128.0b3 (treeherder build) running macOS 14, Ubuntu 20.04 and Win 11.
Comment 15•17 days ago
|
||
Comment on attachment 9406409 [details]
Bug 1900972 - Properly pass the channel map instead of the channel count in FFmpegAudioDecoder.cpp. r?#media-playback-reviewers
Approved for 127.0.1, thanks.
Comment 16•17 days ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-release/rev/c0a044c12ab7
Updated•17 days ago
|
Updated•16 days ago
|
Comment 17•16 days ago
|
||
Verified fixed using Firefox 127.0.1 (20240617164919) on MacOS 14, Windows 10 and Ubuntu 24.04.
Description
•