Closed Bug 1895341 Opened 2 months ago Closed 2 months ago

Add install_type “admin” to the management API

Tracking

(firefox127 fixed)

Status:

RESOLVED FIXED

Milestone:

127 Branch

Tracking Flags:

Tracking

Status

firefox127

---

fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1895341 - Add install_type "admin" to the management API. r?rpl 2 months ago Mike Kaply [:mkaply] 48 bytes, text/x-phabricator-request		Details \| Review

Mike Kaply [:mkaply]

Assignee

Description

•

2 months ago

When an addon is installed via enterprise policy, we should mark the installType as "admin"

This is what Chrome does.

Mike Kaply [:mkaply]

Assignee

Comment 1

•

2 months ago

Attached file Bug 1895341 - Add install_type "admin" to the management API. r?rpl — Details

Pulsebot

Comment 2

•

2 months ago

Pushed by [email protected]:
https://hg.mozilla.org/integration/autoland/rev/9d36e2074dc3
Add install_type "admin" to the management API. r=rpl

tszentpeteri

Comment 3

•

2 months ago

Backed out for causing xpcshell failures in test_extensionsettings.js.

[task 2024-05-09T15:38:15.142Z] 15:38:15     INFO -  TEST-START | browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js
[task 2024-05-09T15:38:18.501Z] 15:38:18  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js | xpcshell return code: 0
[task 2024-05-09T15:38:18.501Z] 15:38:18     INFO -  TEST-INFO took 3359ms
[task 2024-05-09T15:38:18.501Z] 15:38:18     INFO -  >>>>>>>
[task 2024-05-09T15:38:18.502Z] 15:38:18     INFO -  PID 12075 | [Parent 12075, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2925
[task 2024-05-09T15:38:18.503Z] 15:38:18     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-05-09T15:38:18.503Z] 15:38:18     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-05-09T15:38:18.504Z] 15:38:18     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-05-09T15:38:18.504Z] 15:38:18     INFO -  running event loop
[task 2024-05-09T15:38:18.504Z] 15:38:18     INFO -  browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js | Starting setup setup
[task 2024-05-09T15:38:18.504Z] 15:38:18     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2024-05-09T15:38:18.504Z] 15:38:18     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095546	addons.manager	DEBUG	Application has been upgraded"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095552	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.sys.mjs"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095556	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/SitePermsAddonProvider.sys.mjs"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095556	addons.manager	DEBUG	Starting provider: XPIProvider"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095556	addons.xpi	DEBUG	startup"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095556	addons.xpi	DEBUG	List of built-in add-ons is missing or invalid.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.sys.mjs :: startup :: line 2503"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.sys.mjs:2503
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  callProvider()@resource://gre/modules/AddonManager.sys.mjs:225
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  _startProvider()@resource://gre/modules/AddonManager.sys.mjs:534
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  startup()@resource://gre/modules/AddonManager.sys.mjs:747
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  startup()@resource://gre/modules/AddonManager.sys.mjs:3640
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  observe()@resource://gre/modules/amManager.sys.mjs:73
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  promiseStartupManager()@resource://testing-common/AddonTestUtils.sys.mjs:853
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  setup()@/builds/worker/workspace/build/tests/xpcshell/tests/browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js:56
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  _run_next_test/<()@/builds/worker/workspace/build/tests/xpcshell/head.js:1759
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  _run_next_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:1759
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  run()@/builds/worker/workspace/build/tests/xpcshell/head.js:808
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  _do_main()@/builds/worker/workspace/build/tests/xpcshell/head.js:245
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  _execute_test()@/builds/worker/workspace/build/tests/xpcshell/head.js:596
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  -e:1"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095560	addons.xpi	INFO	SystemAddonLocation directory is missing"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095573	addons.xpi	INFO	Removing all system add-on upgrades."
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095574	addons.xpi	DEBUG	checkForChanges"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095574	addons.xpi	DEBUG	Loaded add-on state: ${}"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095576	addons.xpi	DEBUG	scanForChanges changed: false, state: {}"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095577	addons.xpi	DEBUG	Empty XPI database, setting schema version preference to 36"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095577	addons.xpi	DEBUG	No changes found"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095584	addons.manager	DEBUG	Registering shutdown blocker for XPIProvider"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095584	addons.manager	DEBUG	Provider finished startup: XPIProvider"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  "CONSOLE_MESSAGE: (info) 1715269095584	addons.manager	DEBUG	Completed startup sequence"
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  (xpcshell/head.js) | test setup finished (2)
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js | Starting test_extensionsettings
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  (xpcshell/head.js) | test test_extensionsettings pending (2)
[task 2024-05-09T15:38:18.517Z] 15:38:18     INFO -  TEST-PASS | browser/components/enterprisepolicies/tests/xpcshell/test_extensionsettings.js | test_extensionsettings - [test_extensionsettings : 44] Sanity check the temporary file doesn't exist. - true == true

Flags: needinfo?(mozilla)

Mike Kaply [:mkaply]

Assignee

Comment 4

•

2 months ago

I tested the heck out of this and everything passed locally. Argh.

Flags: needinfo?(mozilla)

Pulsebot

Comment 5

•

2 months ago

Pushed by [email protected]:
https://hg.mozilla.org/integration/autoland/rev/cd8eb3f4b039
Add install_type "admin" to the management API. r=rpl

Natalia Csoregi [:nataliaCs]

Comment 6

•

2 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/cd8eb3f4b039

Status: ASSIGNED → RESOLVED

Closed: 2 months ago

status-firefox127: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 127 Branch

William Durand [:willdurand]

Updated

•

2 months ago

Keywords: dev-doc-needed

rbloor

Comment 7

•

1 month ago

MDN content changes are ready for review

MDN content Release note for management API install_type “admin” #33714
BCD install_type added to management API #23155

Flags: needinfo?(mozilla)

rbloor

Updated

•

1 month ago

Keywords: dev-doc-needed → dev-doc-complete

Mike Kaply [:mkaply]

Assignee

Comment 8

•

1 month ago

Sorry, this looked good to me.

Flags: needinfo?(mozilla)

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Add install_type “admin” to the management API

Categories

(WebExtensions :: General, enhancement, P3)

Tracking

(firefox127 fixed)

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

(Keywords: dev-doc-complete)

Crash Data

Security

(public)

User Story

Attachments

(1 file)

Description

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Updated

Comment 7

Updated

Comment 8

Attachment

General

Description

File Name

Content Type